[PATCH] server: remove superflous NULL check (Coverity)

Marcus Meissner marcus at jet.franken.de
Tue Jun 14 06:38:45 CDT 2011


Hi,

we deref acceptsock->fd in all pathes leading here.
CID 2025

Ciao, Marcus
---
 server/sock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/server/sock.c b/server/sock.c
index b0efc16..9f62da2 100644
--- a/server/sock.c
+++ b/server/sock.c
@@ -777,7 +777,7 @@ static int accept_into_socket( struct sock *sock, struct sock *acceptsock )
     acceptsock->family  = sock->family;
     acceptsock->wparam  = 0;
     acceptsock->deferred = NULL;
-    if (acceptsock->fd) release_object( acceptsock->fd );
+    release_object( acceptsock->fd );
     acceptsock->fd = newfd;
 
     clear_error();
-- 
1.7.3.4




More information about the wine-patches mailing list