[PATCH] shlwapi: Removed superflous NULL check (Coverity)

Marcus Meissner marcus at jet.franken.de
Wed Jun 15 03:07:55 CDT 2011


Hi,

Can't be NULL in the control flow, as CharNext* also does not
return NULL.

CID 2021, 2020.

Ciao, Marcus
---
 dlls/shlwapi/string.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/shlwapi/string.c b/dlls/shlwapi/string.c
index 6102f3c..07ca0c6 100644
--- a/dlls/shlwapi/string.c
+++ b/dlls/shlwapi/string.c
@@ -2478,7 +2478,7 @@ char WINAPI SHStripMneumonicA(LPCSTR lpszStr)
       if (*lpszTmp != '&')
         ch =  *lpszTmp;
 
-      while (lpszIter && *lpszIter)
+      while (*lpszIter)
       {
         lpszTmp = CharNextA(lpszIter);
         *lpszIter = *lpszTmp;
@@ -2512,7 +2512,7 @@ WCHAR WINAPI SHStripMneumonicW(LPCWSTR lpszStr)
       if (*lpszTmp != '&')
         ch =  *lpszTmp;
 
-      while (lpszIter && *lpszIter)
+      while (*lpszIter)
       {
         lpszTmp = lpszIter + 1;
         *lpszIter = *lpszTmp;
-- 
1.7.3.4




More information about the wine-patches mailing list