[PATCH 1/4] include: Added raw input constants and a missing function prototype (try 2)

Vincas Miliūnas vincas.miliunas at gmail.com
Wed Jun 15 02:44:31 CDT 2011


Patch update, based on the feedback: http://www.winehq.org/pipermail/wine-devel/2011-June/090614.html

The test patch is now applied before implementation, using todo_wine to ignore failures.

I've removed a few abusive tests, that crashed WINE's stub implementation.

To test the actual working cycle (processing of WM_INPUT messages), there needs to be an implementation that sends those WM_INPUT messages. So I've rigged the simulation test with a timer and it will now wait for 5 seconds, before making sure WM_INPUT will not arrive.

The request definitions, process structure fields and server-side implementation were merged into a single patch.

Other changelog:
* removed some unnecessary curly brackets
* used trinary operator instead of if ... else for some return statements
* fixed an issue of returning FALSE instead of -1 in case of an error in GetRawInputDeviceInfoW
* fixed to consistently declare usage_page/usage as unsigned short for structure fields
* fixed a grammatical error and few misscopy-pasted log messages
* fixed lparam casting to lparam_t instead of ULONG_PTR
* fixed an issue, where device name was not transferring the null terminator
* removed two unused variables in the tests and added #include <wchar.h> for wcslen prototype declaration

The tests "failed" on W7PROX64 (64 bit input), because the line
    skip("Skipping Input_blackbox test on non-US keyboard\n");
kills the test at that point. The raw input function tests were not even executed. I guess that should be fixed, because it's not aware about the new code added.

---
 include/winuser.h |  109 +++++++++++++++++++++++++++++++++++++++++++++++------
 1 files changed, 97 insertions(+), 12 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-include-Added-raw-input-constants-and-a-missing-func.patch
Type: text/x-patch
Size: 5008 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20110615/9da838a4/attachment-0001.bin>


More information about the wine-patches mailing list