[PATCH] msi: removed useless NULL check (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun Jun 26 10:17:38 CDT 2011


Hi,

db is derefenced right above, and the codepath leading
here has it always valid.

CID 2006.

Ciao, Marcus
---
 dlls/msi/suminfo.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/dlls/msi/suminfo.c b/dlls/msi/suminfo.c
index ccde725..e0c99b8 100644
--- a/dlls/msi/suminfo.c
+++ b/dlls/msi/suminfo.c
@@ -516,9 +516,7 @@ UINT WINAPI MsiGetSummaryInformationW( MSIHANDLE hDatabase,
         msiobj_release( &si->hdr );
     }
 
-    if( db )
-        msiobj_release( &db->hdr );
-
+    msiobj_release( &db->hdr );
     return ret;
 }
 
-- 
1.7.3.4




More information about the wine-patches mailing list