shell32: Don't pass an unitialized size to RegGetValue().

Michael Stefaniuc mstefani at redhat.de
Wed Jun 29 14:55:57 CDT 2011


That is valid only if the data pointer is NULL which it isn't in this
case.
---
This fixes spurios winetest failures (ERROR_MORE_DATA) on different
linux machines: http://test.winehq.org/data/tests/shell32:shellpath.html


 dlls/shell32/shellpath.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c
index aed7ceb..9aa1813 100644
--- a/dlls/shell32/shellpath.c
+++ b/dlls/shell32/shellpath.c
@@ -3224,7 +3224,8 @@ static HRESULT WINAPI knownfolder_GetCategory(
 {
     struct knownfolder *knownfolder = impl_from_IKnownFolder(iface);
     HRESULT hr = S_OK;
-    DWORD dwSize, dwType;
+    DWORD dwSize = sizeof(DWORD);
+    DWORD dwType;
 
     TRACE("%p, %p\n", knownfolder, pCategory);
 
-- 
1.7.6.rc3



More information about the wine-patches mailing list