[PATCH] msi: pointer to out of scope local variable (Coverity)

Marcus Meissner meissner at suse.de
Fri Mar 4 06:48:27 CST 2011


Hi,

number goes out of scope with a pointer pointing to it.

CID 2000

Ciao, Marcus
---
 dlls/msi/table.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/table.c b/dlls/msi/table.c
index 739e189..cdbdd58 100644
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -1143,6 +1143,8 @@ static UINT msi_stream_name( const MSITABLEVIEW *tv, UINT row, LPWSTR *pstname )
         type = tv->columns[i].type;
         if ( type & MSITYPE_KEY )
         {
+            WCHAR number[0x20];
+
             r = TABLE_fetch_int( view, row, i+1, &ival );
             if ( r != ERROR_SUCCESS )
                 goto err;
@@ -1159,7 +1161,6 @@ static UINT msi_stream_name( const MSITABLEVIEW *tv, UINT row, LPWSTR *pstname )
             else
             {
                 static const WCHAR fmt[] = { '%','d',0 };
-                WCHAR number[0x20];
                 UINT n = bytes_per_column( tv->db, &tv->columns[i], LONG_STR_BYTES );
 
                 switch( n )
-- 
1.7.1



More information about the wine-patches mailing list