mshtml,shdocvw: Initialize OLEINPLACEFRAMEINFO.cb for IOleInPlaceSite::GetWindowContext

Thomas Faber thfabba at gmx.de
Wed Mar 16 05:21:26 CDT 2011


Hi,

the documentation for the OLEINPLACEFRAMEINFO structure [1] says
that the 'cb' member must be initialized before passing the structure
to IOleInPlaceSite::GetWindowContext (where the rest of it will be
filled).
In addition to the fix, I have updated the corresponding
tests to check this member instead of setting it, and they pass
on Windows as expected [2]. I've used a >= compare for future
version compatibility.
I've done a grep on GetWindowContext, so I _think_ I didn't miss
any places where this should have been changed. ;)
This solves an issue over at ReactOS [3].

Regards,
Tom

[1] http://msdn.microsoft.com/en-us/library/ms693737(v=vs.85).aspx
[2] https://testbot.winehq.org/JobDetails.pl?Key=9969
    https://testbot.winehq.org/JobDetails.pl?Key=9972
    https://testbot.winehq.org/JobDetails.pl?Key=9973
    https://testbot.winehq.org/JobDetails.pl?Key=9983
[3] http://www.reactos.org/bugzilla/show_bug.cgi?id=6011
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-mshtml-shdocvw-Initialize-OLEINPLACEFRAMEINFO.cb-for.txt
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20110316/80ef019f/attachment-0001.txt>


More information about the wine-patches mailing list