[PATCH] winebuild: mark up fallthrough switch cases (Coverity)

Marcus Meissner marcus at jet.franken.de
Tue Mar 29 08:33:04 CDT 2011


---
 tools/winebuild/spec32.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/winebuild/spec32.c b/tools/winebuild/spec32.c
index e16260a..d2c3635 100644
--- a/tools/winebuild/spec32.c
+++ b/tools/winebuild/spec32.c
@@ -199,10 +199,10 @@ static void output_relay_debug( DLLSPEC *spec )
             output( "\t.cfi_adjust_cfa_offset 40\n" );
             switch (args)
             {
-            default: output( "\tmovq %%%s,72(%%rsp)\n", is_float_arg( odp, 3 ) ? "xmm3" : "r9" );
-            case 3:  output( "\tmovq %%%s,64(%%rsp)\n", is_float_arg( odp, 2 ) ? "xmm2" : "r8" );
-            case 2:  output( "\tmovq %%%s,56(%%rsp)\n", is_float_arg( odp, 1 ) ? "xmm1" : "rdx" );
-            case 1:  output( "\tmovq %%%s,48(%%rsp)\n", is_float_arg( odp, 0 ) ? "xmm0" : "rcx" );
+            default: output( "\tmovq %%%s,72(%%rsp)\n", is_float_arg( odp, 3 ) ? "xmm3" : "r9" ); /* FALLTHROUGH */
+            case 3:  output( "\tmovq %%%s,64(%%rsp)\n", is_float_arg( odp, 2 ) ? "xmm2" : "r8" ); /* FALLTHROUGH */
+            case 2:  output( "\tmovq %%%s,56(%%rsp)\n", is_float_arg( odp, 1 ) ? "xmm1" : "rdx" ); /* FALLTHROUGH */
+            case 1:  output( "\tmovq %%%s,48(%%rsp)\n", is_float_arg( odp, 0 ) ? "xmm0" : "rcx" ); /* FALLTHROUGH */
             case 0:  break;
             }
             output( "\tleaq 40(%%rsp),%%r8\n" );
-- 
1.7.3.4



More information about the wine-patches mailing list