[PATCH] msi: Fixed check_flag_combo macro (Coverity)
Marcus Meissner
meissner at suse.de
Fri May 6 10:33:42 CDT 2011
The macro was always FALSE, as
x & y == ~y
is always FALSE. x& y == y was clearly intended.
CID 1448
Ciao, Marcus
---
dlls/msi/action.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 58152a4..3caf6f4 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -6955,7 +6955,7 @@ static UINT ACTION_RemoveODBC( MSIPACKAGE *package )
#define ENV_MOD_PREFIX 0x80000000
#define ENV_MOD_MASK 0xC0000000
-#define check_flag_combo(x, y) ((x) & ~(y)) == (y)
+#define check_flag_combo(x, y) (((x) & (y)) == (y))
static UINT env_parse_flags( LPCWSTR *name, LPCWSTR *value, DWORD *flags )
{
--
1.7.1
More information about the wine-patches
mailing list