[PATCH 2/5] d3d10: Implement D3D10StateBlockMaskDisableCapture().

Henri Verbeet hverbeet at codeweavers.com
Tue Nov 15 18:32:29 CST 2011


On 2011-11-15 23:50, Matteo Bruni wrote:
> 2011/11/15 Henri Verbeet <hverbeet at codeweavers.com>:
>> ---
> 
>> +    UINT end = start_idx + count;
> 
>> +    start_idx += 7;
>> +    memset(&field[start_idx >> 3], 0, (end >> 3) - (start_idx >> 3));
> 
> Isn't that dangerous if count is < 7 (assuming that is a valid value)?
Yeah, the patch is fairly broken in general for that case, actually.
Please use the attached patch instead, it's probably more readable too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-d3d10-Implement-D3D10StateBlockMaskDisableCapture.patch
Type: application/text
Size: 13906 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20111116/ed47aa9c/attachment-0001.bin>


More information about the wine-patches mailing list