mmdevapi: SHAREDMODE_EXCLUSIVE + EVENTCALLBACK is too ... exclusive for now.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Tue Nov 22 03:43:00 CST 2011


My patch initially used AUDCLNT_E_EXCLUSIVE_MODE_NOT_ALLOWED.
However, native does not know the sequence
IsFormatSupported(EXCL) => S_OK
Initialize(EXCL)=> NOT_ALLOWED
so we'd have to add todo_wine should we ever test that
as well as present surprising error codes to the app.

OTOH, the sequence
IsFormatSupported(EXCL) => S_OK
Initialize(EXCL)=> DEVICE_IN_USE
is perfectly normal on native, so let's use it.
I prefer that against E_NOTIMPL which is also unknown to
native's mmdevapi (even though Vista does not implement it IIRC from MSDN).

One may object against presenting the error "in use"
that may mislead users.  Hopefully, they'll also
see the fixme and know what's going on.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mmdevapi-SHAREDMODE_EXCLUSIVE-EVENTCALLBACK-is-to.patch
Type: application/octet-stream
Size: 2176 bytes
Desc: 0001-mmdevapi-SHAREDMODE_EXCLUSIVE-EVENTCALLBACK-is-to.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20111122/ffcd4a7a/attachment.obj>


More information about the wine-patches mailing list