[PATCH] netapi32: Also check GetUserName here (Coverity)
Marcus Meissner
meissner at suse.de
Wed Sep 7 08:29:42 CDT 2011
Hi,
Return value is otherwise checked.
CID 5135
Ciao, Marcus
---
dlls/netapi32/access.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/dlls/netapi32/access.c b/dlls/netapi32/access.c
index 255e51b..7cd05fc 100644
--- a/dlls/netapi32/access.c
+++ b/dlls/netapi32/access.c
@@ -437,7 +437,10 @@ NetUserGetLocalGroups(LPCWSTR servername, LPCWSTR username, DWORD level,
size = UNLEN + 1;
NetApiBufferAllocate(size * sizeof(WCHAR), (LPVOID*)¤tuser);
- GetUserNameW(currentuser, &size);
+ if (!GetUserNameW(currentuser, &size)) {
+ NetApiBufferFree(currentuser);
+ return ERROR_NOT_ENOUGH_MEMORY;
+ }
if (lstrcmpiW(username, currentuser) && NETAPI_FindUser(username))
{
--
1.7.1
More information about the wine-patches
mailing list