programs/services: Log error in scmdatabase_autostart_services. (RESEND^3)

Gerald Pfeifer gerald at pfeifer.com
Wed Sep 7 18:45:00 CDT 2011


I did not see any responses for my submission of this in June and again
in July (and I did check the mailing list archives this time ;-).

An alternative patch would be my original patch submitted in February 
  http://www.winehq.org/pipermail/wine-patches/2011-February/098886.html
though I figure warning may be preferrable than just removing the unused
variable, thus the new patch.

Gerald
---
 programs/services/services.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/programs/services/services.c b/programs/services/services.c
index 35edbba..6a93d7d 100644
--- a/programs/services/services.c
+++ b/programs/services/services.c
@@ -291,11 +291,15 @@ static void scmdatabase_autostart_services(struct scmdatabase *db)
     {
         DWORD err;
         const WCHAR *argv[2];
+
         service = services_list[i];
         argv[0] = service->name;
         argv[1] = NULL;
+
         err = service_start(service, 1, argv);
-        /* FIXME: do something if the service failed to start */
+        if (err != ERROR_SUCCESS)
+            WINE_ERR("Failure to auto start service %s, error code %d\n",
+                     wine_dbgstr_w(service->name),err);
         release_service(service);
     }
 
-- 
1.7.4.1



More information about the wine-patches mailing list