[PATCH 4/4] winmm: Never write silence, mmdevapi must handle underruns.

[Joerg-Cyril.Hoehle at t-systems.com]

Hi,

This is the patch I'm feeling uncomfortable with.
Not because it would be incorrect.
It solves bug #28027 and bug #27937. It might cure
more bugs about stuttering/choppy audio.

It's also part of a path that'll allow me to equate
mmdevapi:GetPosition with winmm:GetPosition mid-term.

The problem is that because of double errors and the
PulseAudio underrun issue, there's potential that
this patch creates regressions.  Perhaps a bogus PA depends
on the current behavior to reduce the risk of underruns?

So the patch is the right thing, but perhaps not the right time.

Hmm, perhaps I need to first submit the "winmm: Fix GetPosition when
stopping" patch (not yet finalized).  Did I mention double errors?

Anyway, you get the idea. Feedback in bug #27937 is welcome.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-winmm-Never-write-silence-mmdevapi-must-handle-under.patch
Type: application/octet-stream
Size: 1250 bytes
Desc: 0004-winmm-Never-write-silence-mmdevapi-must-handle-under.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20110922/7a67d3f5/attachment.obj>