[PATCH] winecfg: Fixed use-after-free (Coverity)
Marcus Meissner
marcus at jet.franken.de
Fri Aug 17 13:53:43 CDT 2012
kind of obvious. CID 714116
---
programs/winecfg/drivedetect.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/programs/winecfg/drivedetect.c b/programs/winecfg/drivedetect.c
index 34b113e..b0d827d 100644
--- a/programs/winecfg/drivedetect.c
+++ b/programs/winecfg/drivedetect.c
@@ -287,7 +287,6 @@ static void ensure_drive_c_is_mapped(void)
len = snprintf(NULL, 0, "%s/../drive_c", configdir);
drive_c_dir = HeapAlloc(GetProcessHeap(), 0, len);
snprintf(drive_c_dir, len, "%s/../drive_c", configdir);
- HeapFree(GetProcessHeap(), 0, drive_c_dir);
if (stat(drive_c_dir, &buf) == 0)
{
@@ -300,6 +299,7 @@ static void ensure_drive_c_is_mapped(void)
{
report_error(NO_DRIVE_C);
}
+ HeapFree(GetProcessHeap(), 0, drive_c_dir);
}
int autodetect_drives(void)
--
1.7.3.4
More information about the wine-patches
mailing list