[PATCH] advapi32: do not use invalid pSD value (Coverity)
Marcus Meissner
meissner at suse.de
Thu Dec 27 13:00:27 CST 2012
Introduced by 331b99cf191b39caf87db8c3902d680007317ade, pSD
is recently freed. I suspect it is supposed to be NULL.
Ciao, Marcus
---
dlls/advapi32/tests/service.c | 2 +-
1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c
index 5fcd4cb..65702ad 100644
--- a/dlls/advapi32/tests/service.c
+++ b/dlls/advapi32/tests/service.c
@@ -1853,7 +1853,7 @@ static void test_sequence(void)
/* Test using QueryServiceObjectSecurity to obtain security information */
SetLastError(0xdeadbeef);
- bret = pQueryServiceObjectSecurity(svc_handle, DACL_SECURITY_INFORMATION, pSD, 0, &n1);
+ bret = pQueryServiceObjectSecurity(svc_handle, DACL_SECURITY_INFORMATION, NULL, 0, &n1);
error = GetLastError();
ok(!bret, "Expected QueryServiceObjectSecurity to fail: result %d\n", bret);
ok(error == ERROR_INSUFFICIENT_BUFFER, "Expected ERROR_INSUFFICIENT_BUFFER, got %d\n", error);
--
1.7.10.4
More information about the wine-patches
mailing list