winmm: GetCurrentPadding is superfluous while recording.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Tue Jan 10 07:14:44 CST 2012


Hi,

now winmm recording does not depend on chunking by mmdevapi.

+        if(packet > 0)
+            WARN("losing %u frames\n", packet);
That part is interesting.  Another approach would have been to check whether
all of GetData could be stuffed into winmm buffers and use ReleaseBuffer(0) if not
(much more complicated in the presence of several buffers).

As long as winmm supplies enough buffers in advance, that doesn't matter.

With that in place, the "Fix AudioCaptureClient protocol" patches can be applied on
the winmm side. I have not checked the dsound code.

I'm sorry winmm:ACMPullData was broken by my former notification patch.  I'll have to fix that.
ACMPullData is also not very robust (return; after GetBuffer will prevent any subsequent GetBuffer
with OUT_OF_ORDER).

Regards,
 Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-winmm-GetCurrentPadding-is-superfluous-while-record.patch
Type: application/octet-stream
Size: 2621 bytes
Desc: 0001-winmm-GetCurrentPadding-is-superfluous-while-record.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20120110/33d4f978/attachment.obj>


More information about the wine-patches mailing list