setupapi: Correctly report errors in fake_dlls_callback (Coverity) (try 2)
Frédéric Delanoy
frederic.delanoy at gmail.com
Thu Jan 19 10:14:21 CST 2012
'ret'urn value was initially set to TRUE and never updated.
CID 1492
---
dlls/setupapi/install.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/dlls/setupapi/install.c b/dlls/setupapi/install.c
index 947a512..96eb914 100644
--- a/dlls/setupapi/install.c
+++ b/dlls/setupapi/install.c
@@ -701,7 +701,6 @@ static BOOL register_dlls_callback( HINF hinf, PCWSTR field, void *arg )
static BOOL fake_dlls_callback( HINF hinf, PCWSTR field, void *arg )
{
INFCONTEXT context;
- BOOL ret = TRUE;
BOOL ok = SetupFindFirstLineW( hinf, field, NULL, &context );
for (; ok; ok = SetupFindNextLine( &context, &context ))
@@ -730,9 +729,8 @@ static BOOL fake_dlls_callback( HINF hinf, PCWSTR field, void *arg )
done:
HeapFree( GetProcessHeap(), 0, path );
- if (!ret) break;
}
- return ret;
+ return TRUE;
}
/***********************************************************************
--
1.7.8.3
More information about the wine-patches
mailing list