wined3d: downgrade a noisy FIXME to a WARN

Austin English austinenglish at gmail.com
Sat Jan 28 14:19:22 CST 2012


Follow up to http://www.winehq.org/pipermail/wine-patches/2012-January/110971.html.
I was hoping to get it in before 1.4, to reduce users asking about it
in #winehq/forums.

I know Henri feels it should be properly fixed instead, but given
http://www.winehq.org/pipermail/wine-devel/2012-January/093977.html, I
don't see that happening, and certainly not before 1.4. No one has
sent a simple downgrade patch, instead opting to go with the
FIXME_once approach. Hopefully this is a fair compromise.

Cheers,
Austin
-------------- next part --------------
diff --git a/dlls/wined3d/resource.c b/dlls/wined3d/resource.c
index da631d6..353a653 100644
--- a/dlls/wined3d/resource.c
+++ b/dlls/wined3d/resource.c
@@ -73,7 +73,7 @@ static void resource_check_usage(DWORD usage)
             | WINED3DUSAGE_OVERLAY;
 
     if (usage & ~handled)
-        FIXME("Unhandled usage flags %#x.\n", usage & ~handled);
+        WARN("Unhandled usage flags %#x.\n", usage & ~handled);
 }
 
 HRESULT resource_init(struct wined3d_resource *resource, struct wined3d_device *device,


More information about the wine-patches mailing list