[4/6]comctl32: code cleaning

Daniel Jelinski djelinski1 at gmail.com
Fri Jul 13 14:58:38 CDT 2012


-------------- next part --------------
From 23bd8cf35c6c4f1e59a020618efaa36c95fe68a9 Mon Sep 17 00:00:00 2001
From: Daniel Jelinski <djelinski1 at gmail.com>
Date: Fri, 13 Jul 2012 20:47:45 +0200
Subject: [PATCH 4/6] comctl32: code cleaning

Inlined TREEVIEW_RBUTTONUP
---
 dlls/comctl32/treeview.c |   25 ++++++-------------------
 1 files changed, 6 insertions(+), 19 deletions(-)

diff --git a/dlls/comctl32/treeview.c b/dlls/comctl32/treeview.c
index 88c1ff4..b784924 100644
--- a/dlls/comctl32/treeview.c
+++ b/dlls/comctl32/treeview.c
@@ -208,7 +208,6 @@ static VOID TREEVIEW_Invalidate(const TREEVIEW_INFO *, const TREEVIEW_ITEM *);
 static LRESULT TREEVIEW_DoSelectItem(TREEVIEW_INFO *, INT, HTREEITEM, INT);
 static VOID TREEVIEW_SetFirstVisible(TREEVIEW_INFO *, TREEVIEW_ITEM *, BOOL);
 static LRESULT TREEVIEW_EnsureVisible(TREEVIEW_INFO *, HTREEITEM, BOOL);
-static LRESULT TREEVIEW_RButtonUp(const TREEVIEW_INFO *, const POINT *);
 static LRESULT TREEVIEW_EndEditLabelNow(TREEVIEW_INFO *infoPtr, BOOL bCancel);
 static VOID TREEVIEW_UpdateScrollBars(TREEVIEW_INFO *infoPtr);
 static LRESULT TREEVIEW_HScroll(TREEVIEW_INFO *, WPARAM);
@@ -4260,7 +4259,12 @@ TREEVIEW_RButtonDown(TREEVIEW_INFO *infoPtr, LPARAM lParam)
 	SetFocus(infoPtr->hwnd);
 	if(!TREEVIEW_SendSimpleNotify(infoPtr, NM_RCLICK))
 	{
-	    TREEVIEW_RButtonUp(infoPtr, &ht.pt);
+	    /* Change to screen coordinate for WM_CONTEXTMENU */
+	    ClientToScreen(infoPtr->hwnd, &ht.pt);
+
+	    /* Send a WM_CONTEXTMENU message in response to the RBUTTONUP */
+	    SendMessageW(infoPtr->hwnd, WM_CONTEXTMENU,
+		(WPARAM)infoPtr->hwnd, MAKELPARAM(ht.pt.x, ht.pt.y));
 	}
     }
 
@@ -4268,23 +4272,6 @@ TREEVIEW_RButtonDown(TREEVIEW_INFO *infoPtr, LPARAM lParam)
 }
 
 static LRESULT
-TREEVIEW_RButtonUp(const TREEVIEW_INFO *infoPtr, const POINT *pPt)
-{
-    TVHITTESTINFO ht;
-
-    ht.pt = *pPt;
-
-    /* Change to screen coordinate for WM_CONTEXTMENU */
-    ClientToScreen(infoPtr->hwnd, &ht.pt);
-
-    /* Send a WM_CONTEXTMENU message in response to the RBUTTONUP */
-    SendMessageW(infoPtr->hwnd, WM_CONTEXTMENU,
-        (WPARAM)infoPtr->hwnd, MAKELPARAM(ht.pt.x, ht.pt.y));
-    return 0;
-}
-
-
-static LRESULT
 TREEVIEW_CreateDragImage(TREEVIEW_INFO *infoPtr, LPARAM lParam)
 {
     TREEVIEW_ITEM *dragItem = (HTREEITEM)lParam;
-- 
1.7.5.4


More information about the wine-patches mailing list