gdi32: add test for SelectClipRgn in metafiles, make it pass (try 2)

Dan Kegel dank at kegel.com
Tue Jun 19 20:08:07 CDT 2012


Adding a simple SelectClipRgn metafile test revealed bugs in
SelectClipRgn metafile support:

- in MFDRV_CreateRegion():
   - RegionSize field, though it seemed to follow the spec, was off by
two compared to windows.  Is the spec wrong?
   - The reserved "objectCount" field didn't have the same value as on Windows

- in MFDRV_ExtSelectClipRgn, generate META_SELECTOBJECT like Windows
does, not META_SELECTCLIPREGION.

Fixing the code to pass the test also fixes bug 30923.

The patch also moves a couple misplaced test calls.

Change since first try: rediffed against current git to account for
the parts Alexandre fixed himself
-------------- next part --------------
A non-text attachment was scrubbed...
Name: metafile-3.patch
Type: application/octet-stream
Size: 6103 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20120619/322b8132/attachment.obj>


More information about the wine-patches mailing list