Changed UrlGetPartA and UrlGetPartW to return the correct (different) values.

Eric Culp eculperic at gmail.com
Wed Mar 21 01:24:35 CDT 2012


On Wed, Mar 21, 2012 at 2:59 AM, Nikolay Sivov <bunglehead at gmail.com> wrote:

> On 3/21/2012 08:58, Eric Culp wrote:
>
>> The two functions have different return values on windows for analogous
>> inputs.
>> Changed to match windows behavior.
>> ---
>>  dlls/shlwapi/url.c |   12 ++++++++++--
>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>
> Please add some tests for that.
>
> I think it's already covered by

dlls/shlwapi/tests/url.c:672
res = pUrlGetPartA("hi", szPart, &dwSize, URL_PART_SCHEME, 0);
ok (res==S_FALSE, "UrlGetPartA(\"hi\") returned %08X\n", res);

and

dlls/shlwapi/tests/url.c:685
res = pUrlGetPartW(hiW, bufW, &dwSize, URL_PART_SCHEME, 0);
todo_wine ok(res==S_OK, "UrlGetPartW(\"hi\") returned %08X\n", res);

Line 686 was the one that previously triggered a todo. Should the todo_wine
be removed?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20120321/39bdefe7/attachment.html>


More information about the wine-patches mailing list