[PATCH] d3dx9_36/tests: Fix broken line test [try2]

Detlef Riekenberg wine.dev at web.de
Thu Nov 29 17:25:31 CST 2012


While inspecting a test failure, i found only
3 possible results for the line test:
- d3dx9_36.dll not present
- all tests skipped
  line.c:146: Tests skipped: Failed to create IDirect3DDevice9 object 0x8876086c
- refcount test failed
  line.c:113: Test failed: Got 5 references to device 0023EA60, expected 2
  (of course with different device pointer)

See: http://test.winehq.org/data/tests/d3dx9_36:line.html

I classify the refcount as implementation detail and removed the refcount test.

--
By by ... Detlef
---
 dlls/d3dx9_36/tests/line.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/d3dx9_36/tests/line.c b/dlls/d3dx9_36/tests/line.c
index dc0c747..891de5a 100644
--- a/dlls/d3dx9_36/tests/line.c
+++ b/dlls/d3dx9_36/tests/line.c
@@ -109,8 +109,7 @@ static void test_create_line(IDirect3DDevice9* device)
     ok(hr == D3D_OK, "Got result %x, expected %x (D3D_OK)\n", hr, D3D_OK);
     expect_mat(&world, &result);
 
-    ref = IDirect3DDevice9_Release(return_device);
-    ok(ref == 2, "Got %x references to device %p, expected 2\n", ref, return_device);
+    IDirect3DDevice9_Release(return_device);
 
     ref = ID3DXLine_Release(line);
     ok(ref == 0, "Got %x references to line %p, expected 0\n", ref, line);
-- 
1.7.5.4




More information about the wine-patches mailing list