testbot/WineRunTask: Treat a missing test summary line as an error.

Francois Gouget fgouget at codeweavers.com
Tue Oct 23 11:23:43 CDT 2012


---

This fixes bug 32004.

 testbot/bin/WineRunTask.pl |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl
index 6f63640..ca72fc7 100755
--- a/testbot/bin/WineRunTask.pl
+++ b/testbot/bin/WineRunTask.pl
@@ -335,11 +335,7 @@ $Task->Status("completed");
 $Task->ChildPid(undef);
 $Task->Ended(time);
 my $TestFailures = CountFailures($FullLogFileName);
-if (defined($TestFailures))
-{
-  $Task->TestFailures($TestFailures);
-}
-else
+if (!defined $TestFailures)
 {
   my $OldUMask = umask(002);
   if (open ERRFILE, ">>$FullErrFileName")
@@ -348,7 +344,9 @@ else
     close ERRFILE;
   }
   umask($OldUMask);
+  $TestFailures = 1;
 }
+$Task->TestFailures($TestFailures);
 $Task->Save();
 $Job->UpdateStatus();
 if ($Task->VM->Role ne "base")
-- 
1.7.10.4



More information about the wine-patches mailing list