gameux: Avoid double free (coverity)

André Hentschel nerv at dawncrow.de
Wed Oct 24 13:52:57 CDT 2012


CID 714025
---
 dlls/gameux/gameexplorer.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/gameux/gameexplorer.c b/dlls/gameux/gameexplorer.c
index 1f51f12..8f30601 100644
--- a/dlls/gameux/gameexplorer.c
+++ b/dlls/gameux/gameexplorer.c
@@ -783,13 +783,15 @@ HRESULT GAMEUX_FindGameInstanceId(
                                              sConfigGDFBinaryPath, &lpValue);
 
                 if(SUCCEEDED(hr))
+                {
                     if(lstrcmpW(lpValue, sGDFBinaryPath)==0)
                     {
                         /* key found, let's copy instance id and exit */
                         hr = (GUIDFromStringW(lpName, pInstanceId) ? S_OK : E_FAIL);
                         found = TRUE;
                     }
-                HeapFree(GetProcessHeap(), 0, lpValue);
+                    HeapFree(GetProcessHeap(), 0, lpValue);
+                }
             }
         }
 
-- 
1.8.0



-- 

Best Regards, André Hentschel


More information about the wine-patches mailing list