[PATCH 5/5] ddraw/tests: Unify the skip messages a bit.
Henri Verbeet
hverbeet at codeweavers.com
Mon Dec 2 05:07:38 CST 2013
---
dlls/ddraw/tests/ddraw1.c | 52 +++++++++++++++++++-------------------
dlls/ddraw/tests/ddraw2.c | 61 ++++++++++++++++++++++-----------------------
dlls/ddraw/tests/ddraw4.c | 47 +++++++++++++++++-----------------
dlls/ddraw/tests/ddraw7.c | 51 +++++++++++++++++++------------------
4 files changed, 104 insertions(+), 107 deletions(-)
diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c
index f8a458c..9126b2f 100644
--- a/dlls/ddraw/tests/ddraw1.c
+++ b/dlls/ddraw/tests/ddraw1.c
@@ -745,13 +745,13 @@ static void test_coop_level_d3d_state(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -847,10 +847,9 @@ static void test_surface_interface_mismatch(void)
goto cleanup;
}
- hr = IDirectDraw_QueryInterface(ddraw, &IID_IDirect3D, (void **)&d3d);
- if (FAILED(hr))
+ if (FAILED(hr = IDirectDraw_QueryInterface(ddraw, &IID_IDirect3D, (void **)&d3d)))
{
- skip("Failed to get the IDirect3D interface, skipping test.\n");
+ skip("D3D interface is not available, skipping test.\n");
goto cleanup;
}
@@ -951,14 +950,14 @@ static void test_viewport(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
window = CreateWindowA("static", "ddraw_test", WS_OVERLAPPEDWINDOW,
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -1083,13 +1082,13 @@ static void test_zenable(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -1208,13 +1207,13 @@ static void test_ck_rgba(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -1376,13 +1375,13 @@ static void test_ck_default(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -1635,7 +1634,7 @@ static void test_surface_qi(void)
* doesn't support e.g. the IDirect3DTexture interfaces. */
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -1715,13 +1714,13 @@ static void test_device_qi(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -1757,7 +1756,7 @@ static void test_wndproc(void)
/* DDSCL_EXCLUSIVE replaces the window's window proc. */
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -2657,7 +2656,8 @@ static void test_initialize(void)
ok(hr == DDERR_ALREADYINITIALIZED, "Initialize returned hr %#x, expected DDERR_ALREADYINITIALIZED.\n", hr);
IDirect3D_Release(d3d);
}
- else skip("Failed to query IDirect3D interface, skipping tests.\n");
+ else
+ skip("D3D interface is not available, skipping test.\n");
hr = IDirectDraw_Initialize(ddraw, NULL);
ok(hr == DD_OK, "Initialize returned hr %#x, expected DD_OK.\n", hr);
hr = IDirectDraw_Initialize(ddraw, NULL);
@@ -2743,13 +2743,13 @@ static void test_clear_rect_count(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -2829,7 +2829,7 @@ static void test_coop_level_activateapp(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -2987,13 +2987,13 @@ static void test_unsupported_formats(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -3226,7 +3226,7 @@ static void test_rt_caps(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -3372,7 +3372,7 @@ static void test_surface_lock(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -3463,7 +3463,7 @@ static void test_surface_discard(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c
index b6c99a7..b84dd51 100644
--- a/dlls/ddraw/tests/ddraw2.c
+++ b/dlls/ddraw/tests/ddraw2.c
@@ -688,13 +688,13 @@ static void test_coop_level_d3d_state(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -804,10 +804,9 @@ static void test_surface_interface_mismatch(void)
goto cleanup;
}
- hr = IDirectDraw2_QueryInterface(ddraw, &IID_IDirect3D2, (void **)&d3d);
- if (FAILED(hr))
+ if (FAILED(hr = IDirectDraw2_QueryInterface(ddraw, &IID_IDirect3D2, (void **)&d3d)))
{
- skip("Failed to get the IDirect3D2 interface, skipping test.\n");
+ skip("D3D interface is not available, skipping test.\n");
goto cleanup;
}
@@ -921,13 +920,13 @@ static void test_depth_blit(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -1075,7 +1074,7 @@ static void test_texture_load_ckey(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
hr = IDirectDraw2_SetCooperativeLevel(ddraw, NULL, DDSCL_NORMAL);
@@ -1184,14 +1183,14 @@ static void test_viewport(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
window = CreateWindowA("static", "ddraw_test", WS_OVERLAPPEDWINDOW,
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw_Release(ddraw);
DestroyWindow(window);
return;
@@ -1201,7 +1200,7 @@ static void test_viewport(void)
ok(SUCCEEDED(hr) || hr == E_NOINTERFACE, "Failed to get d3d interface, hr %#x.\n", hr);
if (FAILED(hr))
{
- skip("Direct3D not available, skipping tests\n");
+ skip("D3D interface is not available, skipping test.\n");
IDirectDraw2_Release(ddraw);
return;
}
@@ -1377,13 +1376,13 @@ static void test_zenable(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -1482,13 +1481,13 @@ static void test_ck_rgba(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -1625,13 +1624,13 @@ static void test_ck_default(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -1832,7 +1831,7 @@ static void test_surface_qi(void)
* doesn't support e.g. the IDirect3DTexture interfaces. */
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -1911,13 +1910,13 @@ static void test_device_qi(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -1953,7 +1952,7 @@ static void test_wndproc(void)
/* DDSCL_EXCLUSIVE replaces the window's window proc. */
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw2 object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -3025,13 +3024,13 @@ static void test_clear_rect_count(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -3297,13 +3296,13 @@ static void test_lighting_interface_versions(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -3414,7 +3413,7 @@ static void test_coop_level_activateapp(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw2 object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -3572,13 +3571,13 @@ static void test_unsupported_formats(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
if (!(device = create_device(ddraw, window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
IDirectDraw2_Release(ddraw);
DestroyWindow(window);
return;
@@ -3853,7 +3852,7 @@ static void test_rt_caps(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -4055,7 +4054,7 @@ static void test_surface_lock(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -4145,7 +4144,7 @@ static void test_surface_discard(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(window);
return;
}
diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c
index a96877a..a35ee15 100644
--- a/dlls/ddraw/tests/ddraw4.c
+++ b/dlls/ddraw/tests/ddraw4.c
@@ -874,7 +874,7 @@ static void test_coop_level_d3d_state(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -971,10 +971,9 @@ static void test_surface_interface_mismatch(void)
hr = IDirectDrawSurface4_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3);
ok(SUCCEEDED(hr), "Failed to QI IDirectDrawSurface3, hr %#x.\n", hr);
- hr = IDirectDraw4_QueryInterface(ddraw, &IID_IDirect3D3, (void **)&d3d);
- if (FAILED(hr))
+ if (FAILED(hr = IDirectDraw4_QueryInterface(ddraw, &IID_IDirect3D3, (void **)&d3d)))
{
- skip("Failed to get the IDirect3D7 interface, skipping test.\n");
+ skip("D3D interface is not available, skipping test.\n");
goto cleanup;
}
@@ -1090,7 +1089,7 @@ static void test_depth_blit(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1238,7 +1237,7 @@ static void test_texture_load_ckey(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
hr = IDirectDraw4_SetCooperativeLevel(ddraw, NULL, DDSCL_NORMAL);
@@ -1344,7 +1343,7 @@ static void test_viewport(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1527,7 +1526,7 @@ static void test_zenable(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1625,7 +1624,7 @@ static void test_ck_rgba(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1765,7 +1764,7 @@ static void test_ck_default(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1958,7 +1957,7 @@ static void test_surface_qi(void)
* doesn't support e.g. the IDirect3DTexture interfaces. */
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -2043,7 +2042,7 @@ static void test_device_qi(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -2077,7 +2076,7 @@ static void test_wndproc(void)
/* DDSCL_EXCLUSIVE replaces the window's window proc. */
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw4 object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -3112,7 +3111,7 @@ static void test_vb_discard(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3228,7 +3227,7 @@ static void test_draw_strided(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3279,7 +3278,7 @@ static void test_clear_rect_count(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3592,7 +3591,7 @@ static void test_lighting_interface_versions(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3695,7 +3694,7 @@ static void test_coop_level_activateapp(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw4 object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -3849,7 +3848,7 @@ static void test_texturemanage(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw4 object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -4015,7 +4014,7 @@ static void test_block_formats_creation(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -4180,7 +4179,7 @@ static void test_unsupported_formats(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -4438,7 +4437,7 @@ static void test_rt_caps(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -4653,7 +4652,7 @@ static void test_surface_lock(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -4752,7 +4751,7 @@ static void test_surface_discard(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create a ddraw object, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c
index 6ab6bba..289d4fd 100644
--- a/dlls/ddraw/tests/ddraw7.c
+++ b/dlls/ddraw/tests/ddraw7.c
@@ -379,7 +379,7 @@ static void test_process_vertices(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create a ddraw object, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -546,7 +546,7 @@ static void test_coop_level_create_device_window(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create a 3D device, skipping test.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
DestroyWindow(focus_window);
return;
}
@@ -840,7 +840,7 @@ static void test_coop_level_d3d_state(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -932,10 +932,9 @@ static void test_surface_interface_mismatch(void)
hr = IDirectDrawSurface7_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3);
ok(SUCCEEDED(hr), "Failed to QI IDirectDrawSurface3, hr %#x.\n", hr);
- hr = IDirectDraw7_QueryInterface(ddraw, &IID_IDirect3D7, (void **)&d3d);
- if (FAILED(hr))
+ if (FAILED(hr = IDirectDraw7_QueryInterface(ddraw, &IID_IDirect3D7, (void **)&d3d)))
{
- skip("Failed to get the IDirect3D7 interface, skipping test.\n");
+ skip("D3D interface is not available, skipping test.\n");
goto cleanup;
}
@@ -1045,7 +1044,7 @@ static void test_depth_blit(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1191,7 +1190,7 @@ static void test_texture_load_ckey(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1289,7 +1288,7 @@ static void test_zenable(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1379,7 +1378,7 @@ static void test_ck_rgba(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1507,7 +1506,7 @@ static void test_ck_default(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1693,7 +1692,7 @@ static void test_surface_qi(void)
* doesn't support e.g. the IDirect3DTexture interfaces. */
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1778,7 +1777,7 @@ static void test_device_qi(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -1812,7 +1811,7 @@ static void test_wndproc(void)
/* DDSCL_EXCLUSIVE replaces the window's window proc. */
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw7 object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -2847,7 +2846,7 @@ static void test_vb_discard(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -2961,7 +2960,7 @@ static void test_draw_strided(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3009,7 +3008,7 @@ static void test_clear_rect_count(void)
0, 0, 640, 480, 0, 0, 0, 0);
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3219,7 +3218,7 @@ static void test_fog_special(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3414,7 +3413,7 @@ static void test_lighting_interface_versions(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3509,7 +3508,7 @@ static void test_coop_level_activateapp(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw7 object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -3663,7 +3662,7 @@ static void test_texturemanage(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create IDirectDraw7 object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -3829,7 +3828,7 @@ static void test_block_formats_creation(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -3994,7 +3993,7 @@ static void test_unsupported_formats(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create D3D device, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
@@ -4254,7 +4253,7 @@ static void test_rt_caps(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -4514,7 +4513,7 @@ static void test_surface_lock(void)
if (!(ddraw = create_ddraw()))
{
- skip("Failed to create ddraw object, skipping tests.\n");
+ skip("Failed to create a ddraw object, skipping test.\n");
return;
}
@@ -4639,7 +4638,7 @@ static void test_surface_discard(void)
if (!(device = create_device(window, DDSCL_NORMAL)))
{
- skip("Failed to create a ddraw object, skipping test.\n");
+ skip("Failed to create a 3D device, skipping test.\n");
DestroyWindow(window);
return;
}
--
1.7.10.4
More information about the wine-patches
mailing list