qmgr: Remove unused IUnknown *outer parameter from object constructor.
Dmitry Timoshkov
dmitry at baikal.ru
Mon Dec 30 03:20:33 CST 2013
Class factory explicitly checks for it:
if (outer) return CLASS_E_NOAGGREGATION;
obj_constructor(outer, &obj);
i.e. outer is always NULL in the object constructor.
---
dlls/qmgr/factory.c | 2 +-
dlls/qmgr/qmgr.c | 4 ++--
dlls/qmgr/qmgr.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dlls/qmgr/factory.c b/dlls/qmgr/factory.c
index 222f5df..f120dae 100644
--- a/dlls/qmgr/factory.c
+++ b/dlls/qmgr/factory.c
@@ -62,7 +62,7 @@ BITS_IClassFactory_CreateInstance(IClassFactory *iface, IUnknown *pUnkOuter, REF
if (pUnkOuter)
return CLASS_E_NOAGGREGATION;
- res = BackgroundCopyManagerConstructor(pUnkOuter, (LPVOID*) &punk);
+ res = BackgroundCopyManagerConstructor((LPVOID*) &punk);
if (FAILED(res))
return res;
diff --git a/dlls/qmgr/qmgr.c b/dlls/qmgr/qmgr.c
index 17b374b..c3c6dbe 100644
--- a/dlls/qmgr/qmgr.c
+++ b/dlls/qmgr/qmgr.c
@@ -138,9 +138,9 @@ BackgroundCopyManagerImpl globalMgr = {
};
/* Constructor for instances of background copy manager */
-HRESULT BackgroundCopyManagerConstructor(IUnknown *pUnkOuter, LPVOID *ppObj)
+HRESULT BackgroundCopyManagerConstructor(LPVOID *ppObj)
{
- TRACE("(%p,%p)\n", pUnkOuter, ppObj);
+ TRACE("(%p)\n", ppObj);
*ppObj = &globalMgr;
return S_OK;
}
diff --git a/dlls/qmgr/qmgr.h b/dlls/qmgr/qmgr.h
index 4a9bb15..8f2281d 100644
--- a/dlls/qmgr/qmgr.h
+++ b/dlls/qmgr/qmgr.h
@@ -84,7 +84,7 @@ extern HANDLE stop_event DECLSPEC_HIDDEN;
extern ClassFactoryImpl BITS_ClassFactory DECLSPEC_HIDDEN;
extern BackgroundCopyManagerImpl globalMgr DECLSPEC_HIDDEN;
-HRESULT BackgroundCopyManagerConstructor(IUnknown *pUnkOuter, LPVOID *ppObj) DECLSPEC_HIDDEN;
+HRESULT BackgroundCopyManagerConstructor(LPVOID *ppObj) DECLSPEC_HIDDEN;
HRESULT BackgroundCopyJobConstructor(LPCWSTR displayName, BG_JOB_TYPE type,
GUID *pJobId, BackgroundCopyJobImpl **job) DECLSPEC_HIDDEN;
HRESULT enum_copy_job_create(BackgroundCopyManagerImpl *qmgr,
--
1.8.5.2
More information about the wine-patches
mailing list