[PATCH] advpack: avoid using sessions uninitialized (Coverity)

Marcus Meissner meissner at suse.de
Mon Jan 7 15:17:36 CST 2013


CID 511091

first error goto done; would lead to a uninitialized use
of sessions

Ciao, Marcus
---
 dlls/advpack/files.c |    3 ++-
 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)

diff --git a/dlls/advpack/files.c b/dlls/advpack/files.c
index c34f6d5..a1d52f8 100644
--- a/dlls/advpack/files.c
+++ b/dlls/advpack/files.c
@@ -708,6 +708,8 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags,
     if (!hCabinet)
         return E_FAIL;
 
+    ZeroMemory(&session, sizeof(SESSION));
+
     pExtract = (void *)GetProcAddress(hCabinet, "Extract");
     if (!pExtract)
     {
@@ -715,7 +717,6 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags,
         goto done;
     }
 
-    ZeroMemory(&session, sizeof(SESSION));
     lstrcpyA(session.Destination, ExpandDir);
 
     if (FileList)
-- 
1.7.10.4




More information about the wine-patches mailing list