[PATCH] dmsynth: remove now useless NULL ptr check (Coverity)

Marcus Meissner meissner at suse.de
Mon Jan 7 15:17:30 CST 2013


CID 966611

!data is useless, as it was dereferenced above.

Lets leave the check out and see if we ever get crashes or not.

Ciao, Marcus
---
 dlls/dmsynth/synth.c |    4 ++--
 1 Datei geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)

diff --git a/dlls/dmsynth/synth.c b/dlls/dmsynth/synth.c
index 4392230..7a966a8 100644
--- a/dlls/dmsynth/synth.c
+++ b/dlls/dmsynth/synth.c
@@ -126,7 +126,7 @@ static HRESULT WINAPI IDirectMusicSynth8Impl_SetNumChannelGroups(LPDIRECTMUSICSY
 static HRESULT WINAPI IDirectMusicSynth8Impl_Download(LPDIRECTMUSICSYNTH8 iface, LPHANDLE hDownload, LPVOID data, LPBOOL free)
 {
     IDirectMusicSynth8Impl *This = impl_from_IDirectMusicSynth8(iface);
-    LPBYTE buffer = (LPBYTE)data;
+    LPBYTE buffer = data;
     DMUS_DOWNLOADINFO *info = (DMUS_DOWNLOADINFO*)buffer;
     ULONG *offsets = ((DMUS_OFFSETTABLE*)(buffer + sizeof(DMUS_DOWNLOADINFO)))->ulOffsetTable;
     LPBYTE object = buffer + sizeof(DMUS_DOWNLOADINFO) + info->dwNumOffsetTableEntries * sizeof(ULONG);
@@ -135,7 +135,7 @@ static HRESULT WINAPI IDirectMusicSynth8Impl_Download(LPDIRECTMUSICSYNTH8 iface,
 
     /* FIXME: Currently we only dump data which is very useful to known how native dmusic behave and debug builtin dmusic */
 
-    if (!hDownload || !data || !free)
+    if (!hDownload || !free)
         return E_POINTER;
 
     if (TRACE_ON(dmsynth))
-- 
1.7.10.4




More information about the wine-patches mailing list