[PATCH] comdlg32: free files on errorpath (Coverity)

Marcus Meissner marcus at jet.franken.de
Thu Jan 31 11:26:47 CST 2013


CID 713352

Ciao, Marcus
---
 dlls/comdlg32/itemdlg.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c
index 96ee5dc..33398b5 100644
--- a/dlls/comdlg32/itemdlg.c
+++ b/dlls/comdlg32/itemdlg.c
@@ -407,7 +407,7 @@ static HRESULT on_default_action(FileDialogImpl *This)
     IShellFolder *psf_parent, *psf_desktop;
     LPITEMIDLIST *pidla;
     LPITEMIDLIST current_folder;
-    LPWSTR fn_iter, files, tmp_files;
+    LPWSTR fn_iter, files = NULL, tmp_files;
     UINT file_count = 0, len, i;
     int open_action;
     HRESULT hr, ret = E_FAIL;
@@ -425,6 +425,7 @@ static HRESULT on_default_action(FileDialogImpl *This)
     if(FAILED(hr))
     {
         ERR("Failed to get pidl for current directory.\n");
+        HeapFree(GetProcessHeap(), 0, files);
         return hr;
     }
 
-- 
1.7.10.4




More information about the wine-patches mailing list