[PATCH 1/2] winhttp: initialize schemes (Coverity)
Marcus Meissner
marcus at jet.franken.de
Wed Jun 12 01:02:51 CDT 2013
1020943 Uninitialized scalar variable
After suggestion by Hans, do it in the helper and also
only in success cases. His testcases now pass :)
Ciao, Marcus
---
dlls/winhttp/request.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c
index 436a02f..3b91c75 100644
--- a/dlls/winhttp/request.c
+++ b/dlls/winhttp/request.c
@@ -1270,8 +1270,10 @@ static BOOL query_auth_schemes( request_t *request, DWORD level, LPDWORD support
return FALSE;
}
scheme = auth_scheme_from_header( buffer );
- if (first && index == 1) *first = scheme;
- *supported |= scheme;
+ if (first && index == 1)
+ *first = *supported = scheme;
+ else
+ *supported |= scheme;
heap_free( buffer );
ret = TRUE;
--
1.7.10.4
More information about the wine-patches
mailing list