testbot: Remove unneeded imports of the Fcntl module, document the others.
Francois Gouget
fgouget at codeweavers.com
Wed Aug 6 18:24:42 CDT 2014
---
testbot/bin/CheckForWinetestUpdate.pl | 1 -
testbot/bin/WineRunTask.pl | 1 -
testbot/web/GetFile.pl | 2 +-
testbot/web/Submit.pl | 4 ++--
4 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/testbot/bin/CheckForWinetestUpdate.pl b/testbot/bin/CheckForWinetestUpdate.pl
index 3bedd88..e54da35 100755
--- a/testbot/bin/CheckForWinetestUpdate.pl
+++ b/testbot/bin/CheckForWinetestUpdate.pl
@@ -37,7 +37,6 @@ sub BEGIN
}
}
-use Fcntl;
use File::Basename;
use File::Compare;
use File::Copy;
diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl
index 9b8f43f..6cffd54 100755
--- a/testbot/bin/WineRunTask.pl
+++ b/testbot/bin/WineRunTask.pl
@@ -35,7 +35,6 @@ sub BEGIN
}
}
-use POSIX qw(:fcntl_h);
use WineTestBot::Config;
use WineTestBot::Jobs;
use WineTestBot::VMs;
diff --git a/testbot/web/GetFile.pl b/testbot/web/GetFile.pl
index 943a445..89f3532 100644
--- a/testbot/web/GetFile.pl
+++ b/testbot/web/GetFile.pl
@@ -20,7 +20,7 @@ use strict;
use Apache2::Const -compile => qw(REDIRECT);
use CGI;
-use Fcntl;
+use Fcntl; # For O_XXX
use WineTestBot::Config;
use WineTestBot::Jobs;
use WineTestBot::Steps;
diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 823be4b..530c133 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -21,9 +21,9 @@ use strict;
package SubmitPage;
use CGI qw(:standard);
-use Fcntl;
+use Fcntl; # For O_XXX
use IO::Handle;
-use POSIX qw(:fcntl_h);
+use POSIX qw(:fcntl_h); # For SEEK_XXX
use File::Basename;
use ObjectModel::BasicPropertyDescriptor;
--
2.0.1
More information about the wine-patches
mailing list