[PATCH] dmime: remove useless NULL check (Coverity)

Marcus Meissner marcus at jet.franken.de
Tue Jul 22 02:08:33 CDT 2014


  pItem = DMUS_PMSGToItem(pPMSG);

just adds an offset to pPMSG which was checked for NULL before.

1225838 Logically dead code
1225839 Logically dead code
---
 dlls/dmime/performance.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/dlls/dmime/performance.c b/dlls/dmime/performance.c
index 92e72fe..25e86f9 100644
--- a/dlls/dmime/performance.c
+++ b/dlls/dmime/performance.c
@@ -388,9 +388,6 @@ static HRESULT WINAPI IDirectMusicPerformance8Impl_SendPMsg(IDirectMusicPerforma
     return E_POINTER;
   }
   pItem = DMUS_PMSGToItem(pPMSG);
-  if (NULL == pItem) {
-    return E_POINTER;
-  }
   if (pItem->bInUse) {
     return DMUS_E_ALREADY_SENT;
   }
@@ -512,9 +509,6 @@ static HRESULT WINAPI IDirectMusicPerformance8Impl_FreePMsg(IDirectMusicPerforma
     return E_POINTER;
   }
   pItem = DMUS_PMSGToItem(pPMSG);
-  if (NULL == pItem) {
-    return E_POINTER;
-  }
   if (pItem->bInUse) {
     /** prevent for freeing PMsg in queue (ie to be processed) */
     return DMUS_E_CANNOT_FREE;
-- 
1.8.4.5




More information about the wine-patches mailing list