cryptnet: continue checking the revocation urls if one is offline

Daniel Lehman dlehman at esri.com
Wed Jul 23 15:42:15 CDT 2014


Before this commit: 

cryptnet: Change guard variable to simplify loop.
http://source.winehq.org/git/wine.git/commitdiff/165d380852dbeb391ef22b63af33dad1f1f5a85c

the loop that checked the revocation urls would break if ret == FALSE.  This only happened if the certificate was definitely revoked, the timeout was reached, or the date in the cert was invalid.  The error code CRYPT_E_REVOCATION_OFFLINE was not treated as a fatal error

The removal of 'ret' changed the behavior so that an offline error will cause the function to bail and skip any remaining urls.  I added an explicit check for CRYPT_E_REVOCATION_OFFLINE so the loop will continue on that specific error or none at all;  any other failure will break early and return as before


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cryptnet-continue-checking-the-revocation-urls-if-o.patch
Type: application/octet-stream
Size: 1003 bytes
Desc: 0001-cryptnet-continue-checking-the-revocation-urls-if-o.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20140723/acc3f99b/attachment.obj>


More information about the wine-patches mailing list