[PATCH] d3drm: avoid potential double free (Coverity)
Marcus Meissner
marcus at jet.franken.de
Tue Apr 7 00:31:34 CDT 2015
1127309 Double free
in error exit, we might get a double free of materials
---
dlls/d3drm/meshbuilder.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/dlls/d3drm/meshbuilder.c b/dlls/d3drm/meshbuilder.c
index b3c5dbf..e4d6d86 100644
--- a/dlls/d3drm/meshbuilder.c
+++ b/dlls/d3drm/meshbuilder.c
@@ -356,7 +356,9 @@ static void clean_mesh_builder_data(struct d3drm_mesh_builder *mesh_builder)
}
mesh_builder->nb_materials = 0;
HeapFree(GetProcessHeap(), 0, mesh_builder->materials);
+ mesh_builder->materials = NULL;
HeapFree(GetProcessHeap(), 0, mesh_builder->material_indices);
+ mesh_builder->material_indices = NULL;
}
static HRESULT WINAPI d3drm_mesh_builder2_QueryInterface(IDirect3DRMMeshBuilder2 *iface, REFIID riid, void **out)
--
1.8.4.5
More information about the wine-patches
mailing list