[PATCH 1/2] oleaut32/tests: Uncomment and fix a test (PVS-Studio)

Michael Stefaniuc mstefani at redhat.de
Mon Jan 19 17:15:56 CST 2015


---
Comment is also wrong as Wine implements the old behavior of failing to
parse. By the time the code was commented out both Win2K and XP where
out and they pass the new tests. Of course the "old behavior" might be
just a test failure.


 dlls/oleaut32/tests/vartest.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/dlls/oleaut32/tests/vartest.c b/dlls/oleaut32/tests/vartest.c
index d15adcb..118aa75 100644
--- a/dlls/oleaut32/tests/vartest.c
+++ b/dlls/oleaut32/tests/vartest.c
@@ -1383,11 +1383,13 @@ static void test_VarParseNumFromStr(void)
 
   /* VB oct char bigger than 7 */
   CONVERT("&o128", NUMPRS_HEX_OCT);
-/*
-  Native versions 2.x of oleaut32 allow this to succeed: later versions and Wine don't
-  EXPECTFAIL;
-  EXPECTRGB(0,FAILDIG);
-*/
+  todo_wine {
+  EXPECT(2,NUMPRS_HEX_OCT,0x40,4,3,0);
+  EXPECTRGB(0,1);
+  EXPECTRGB(1,2);
+  }
+  EXPECTRGB(3,FAILDIG);
+
   /** NUMPRS_PARENS **/
 
   /* Empty parens = error */
-- 
1.8.3.1



More information about the wine-patches mailing list