new patch

Vadim Habarin winerepo at gmail.com
Mon Jun 29 23:47:53 CDT 2015


From: John Rockford <winerepo at gmail.com>
Subject: [4/4] shell32/tests: Remove a misleading test.
Message-Id: <5591BF62.7040402 at reactos.org>
Date: Mon, 1 July 2015 10:46:54 +0600

Please open attached file (.txt)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20150630/9f90a69e/attachment.html>
-------------- next part --------------
From: Thomas Faber <thomas.faber at reactos.org>
Subject: [4/4] shell32/tests: Remove a misleading test.
Message-Id: <5591BF62.7040402 at reactos.org>
Date: Mon, 29 Jun 2015 23:57:54 +0200

This removes the aforementioned test.
It's last to show that the test never fails even with the correct
implementation.

From 48bb9acf90e3d1710268a78d55ac1627744787ee Mon Sep 17 00:00:00 2001
From: Thomas Faber <thomas.faber at reactos.org>
Date: Mon, 29 Jun 2015 16:09:09 -0400
Subject: shell32/tests: Remove a misleading test.

---
 dlls/shell32/tests/shlview.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/dlls/shell32/tests/shlview.c b/dlls/shell32/tests/shlview.c
index af57e60..eafaec5 100644
--- a/dlls/shell32/tests/shlview.c
+++ b/dlls/shell32/tests/shlview.c
@@ -694,7 +694,6 @@ static void test_IFolderView(void)
     HRESULT hr;
     INT ret, count;
     POINT pt;
-    LONG ref1, ref2;
     RECT r;
 
     hr = SHGetDesktopFolder(&desktop);
@@ -822,14 +821,8 @@ if (0)
     hr = IFolderView_GetFolder(fv, &IID_IShellFolder, NULL);
     ok(hr == E_POINTER, "got (0x%08x)\n", hr);
 
-    ref1 = IShellFolder_AddRef(desktop);
-    IShellFolder_Release(desktop);
     hr = IFolderView_GetFolder(fv, &IID_IShellFolder, (void**)&folder);
     ok(hr == S_OK, "got (0x%08x)\n", hr);
-    ref2 = IShellFolder_AddRef(desktop);
-    IShellFolder_Release(desktop);
-    ok(ref1 == ref2 || ref1 + 1 == ref2, /* >= vista */
-       "expected same refcount, got %d\n", ref2);
     ok(desktop == folder, "\n");
     if (folder) IShellFolder_Release(folder);
 

-- 
1.7.1


More information about the wine-patches mailing list