[PATCH 1/5] ddraw: Add DDBLT_COLORFILL validation.
Stefan Dösinger
stefan at codeweavers.com
Mon Mar 16 08:48:52 CDT 2015
---
dlls/ddraw/surface.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c
index cbf11da..8b25cb9 100644
--- a/dlls/ddraw/surface.c
+++ b/dlls/ddraw/surface.c
@@ -1537,6 +1537,28 @@ static HRESULT WINAPI ddraw_surface7_Blt(IDirectDrawSurface7 *iface, RECT *DestR
wined3d_mutex_lock();
+ if (Flags & DDBLT_COLORFILL)
+ {
+ if (src_surface)
+ {
+ wined3d_mutex_unlock();
+ WARN("DDBLT_COLORFILL is not compatible with source surfaces, returning DDERR_INVALIDPARAMS\n");
+ return DDERR_INVALIDPARAMS;
+ }
+ if (!DDBltFx)
+ {
+ wined3d_mutex_unlock();
+ WARN("DDBLT_COLORFILL used with DDBltFx = NULL, returning DDERR_INVALIDPARAMS.\n");
+ return DDERR_INVALIDPARAMS;
+ }
+ if (dst_surface->surface_desc.ddsCaps.dwCaps & DDSCAPS_ZBUFFER)
+ {
+ wined3d_mutex_unlock();
+ WARN("DDBLT_COLORFILL used on a depth buffer, returning DDERR_INVALIDPARAMS.\n");
+ return DDERR_INVALIDPARAMS;
+ }
+ }
+
if (Flags & DDBLT_KEYSRC && (!src_surface || !(src_surface->surface_desc.dwFlags & DDSD_CKSRCBLT)))
{
WARN("DDBLT_KEYDEST blit without color key in surface, returning DDERR_INVALIDPARAMS\n");
--
2.3.2
More information about the wine-patches
mailing list