rsaenh/tests: Mark an old behavior as broken (PVS-Studio)
Michael Stefaniuc
mstefani at redhat.de
Wed Oct 28 05:22:37 CDT 2015
All newer Windows support salt in their AES provider
Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
---
See
https://testbot.winehq.org/JobDetails.pl?Key=17749
On a quick search I didn't find any app in bugzilla that would need this
so kept the old behavior in Wine.
dlls/rsaenh/tests/rsaenh.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/rsaenh/tests/rsaenh.c b/dlls/rsaenh/tests/rsaenh.c
index 439d253..b7616fc 100644
--- a/dlls/rsaenh/tests/rsaenh.c
+++ b/dlls/rsaenh/tests/rsaenh.c
@@ -1166,8 +1166,8 @@ static void test_aes(int keylen)
/* Does AES provider support salt? */
result = CryptGetKeyParam(hKey, KP_SALT, NULL, &dwLen, 0);
- ok((!result && GetLastError() == NTE_BAD_KEY) || result /* Win7 */,
- "expected NTE_BAD_KEY, got %08x\n", GetLastError());
+ todo_wine ok(result || broken(GetLastError() == NTE_BAD_KEY), /* Vista or older */
+ "Expected OK, got last error %d\n", GetLastError());
if (result)
ok(!dwLen, "unexpected salt length %d\n", dwLen);
--
2.4.3
More information about the wine-patches
mailing list