netapi32: Avoid shift overflow for GENERIC_READ_ACCESS and friends. friends.
Gerald Pfeifer
gerald at pfeifer.com
Fri Sep 11 14:31:12 CDT 2015
Strictly speaking we'd only need to cover the 1u << 31 case,
GENERIC_READ_ACCESS that is, but I noticed that in a similar
case a few weeks ago you added it for all cases, Alexandre,
so I figured I'd save you the extra work. ;-)
Gerald
---
dlls/netapi32/netapi32.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dlls/netapi32/netapi32.c b/dlls/netapi32/netapi32.c
index d7af2e0..bb61e7f 100644
--- a/dlls/netapi32/netapi32.c
+++ b/dlls/netapi32/netapi32.c
@@ -506,10 +506,10 @@ static unsigned char ace_flags_to_samba( BYTE flags )
return ret;
}
-#define GENERIC_ALL_ACCESS (1 << 28)
-#define GENERIC_EXECUTE_ACCESS (1 << 29)
-#define GENERIC_WRITE_ACCESS (1 << 30)
-#define GENERIC_READ_ACCESS (1 << 31)
+#define GENERIC_ALL_ACCESS (1u << 28)
+#define GENERIC_EXECUTE_ACCESS (1u << 29)
+#define GENERIC_WRITE_ACCESS (1u << 30)
+#define GENERIC_READ_ACCESS (1u << 31)
static unsigned int access_mask_to_samba( DWORD mask )
{
--
2.5.1
More information about the wine-patches
mailing list