ddraw: Don't memset memory before overwritting it.

Michael Stefaniuc mstefani at redhat.de
Wed Jul 27 09:10:39 CDT 2016


Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
---
Both if and else branches do the memcpy(lpData, ..., dwSize).
lpData is not being used prior to the memcpy and dwSize is unchanged.




 dlls/ddraw/viewport.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dlls/ddraw/viewport.c b/dlls/ddraw/viewport.c
index 5ebc41e..154f9aa 100644
--- a/dlls/ddraw/viewport.c
+++ b/dlls/ddraw/viewport.c
@@ -272,7 +272,6 @@ static HRESULT WINAPI d3d_viewport_GetViewport(IDirect3DViewport3 *iface, D3DVIE
     wined3d_mutex_lock();
 
     dwSize = lpData->dwSize;
-    memset(lpData, 0, dwSize);
     if (!This->use_vp2)
         memcpy(lpData, &(This->viewports.vp1), dwSize);
     else {
@@ -895,7 +894,6 @@ static HRESULT WINAPI d3d_viewport_GetViewport2(IDirect3DViewport3 *iface, D3DVI
 
     wined3d_mutex_lock();
     dwSize = lpData->dwSize;
-    memset(lpData, 0, dwSize);
     if (This->use_vp2)
         memcpy(lpData, &(This->viewports.vp2), dwSize);
     else {
-- 
2.7.4



More information about the wine-patches mailing list