[PATCH 3/3] msctf/tests: Return if the constructor fails. This avoids several clang warnings.
Huw Davies
huw at codeweavers.com
Tue Jan 17 05:41:22 CST 2017
Signed-off-by: Huw Davies <huw at codeweavers.com>
---
dlls/msctf/tests/inputprocessor.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dlls/msctf/tests/inputprocessor.c b/dlls/msctf/tests/inputprocessor.c
index e44eafd..7c12936 100644
--- a/dlls/msctf/tests/inputprocessor.c
+++ b/dlls/msctf/tests/inputprocessor.c
@@ -1550,11 +1550,11 @@ static void test_startSession(void)
ITfDocumentMgr_Release(dmtest);
hr = TextStoreACP_Constructor((IUnknown**)&ts);
- if (SUCCEEDED(hr))
- {
- hr = ITfDocumentMgr_CreateContext(g_dm, cid, 0, (IUnknown*)ts, &cxt, &editCookie);
- ok(SUCCEEDED(hr),"CreateContext Failed\n");
- }
+ ok(SUCCEEDED(hr),"Constructor Failed\n");
+ if (FAILED(hr)) return;
+
+ hr = ITfDocumentMgr_CreateContext(g_dm, cid, 0, (IUnknown*)ts, &cxt, &editCookie);
+ ok(SUCCEEDED(hr),"CreateContext Failed\n");
hr = ITfDocumentMgr_CreateContext(g_dm, cid, 0, NULL, &cxt2, &editCookie);
ok(SUCCEEDED(hr),"CreateContext Failed\n");
--
2.10.2
More information about the wine-patches
mailing list