[13/17] windowscodecs: Use PropVariantCompareEx to compare metadata items.
Dmitry Timoshkov
dmitry at baikal.ru
Mon Jun 19 23:37:35 CDT 2017
Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
---
dlls/windowscodecs/metadatahandler.c | 29 +++--------------------------
1 file changed, 3 insertions(+), 26 deletions(-)
diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c
index ad3da676a7..cdd7420901 100644
--- a/dlls/windowscodecs/metadatahandler.c
+++ b/dlls/windowscodecs/metadatahandler.c
@@ -212,29 +212,6 @@ static HRESULT WINAPI MetadataHandler_GetValueByIndex(IWICMetadataWriter *iface,
return hr;
}
-/* FiXME: Use propsys.PropVariantCompareEx once it's implemented */
-static int propvar_cmp(const PROPVARIANT *v1, const PROPVARIANT *v2)
-{
- LONGLONG value1, value2;
-
- if (v1->vt == VT_LPSTR && v2->vt == VT_LPSTR)
- {
- return lstrcmpA(v1->u.pszVal, v2->u.pszVal);
- }
-
- if (v1->vt == VT_LPWSTR && v2->vt == VT_LPWSTR)
- {
- return lstrcmpiW(v1->u.pwszVal, v2->u.pwszVal);
- }
-
- if (PropVariantToInt64(v1, &value1) != S_OK) return -1;
- if (PropVariantToInt64(v2, &value2) != S_OK) return -1;
-
- value1 -= value2;
- if (value1) return value1 < 0 ? -1 : 1;
- return 0;
-}
-
static HRESULT WINAPI MetadataHandler_GetValue(IWICMetadataWriter *iface,
const PROPVARIANT *schema, const PROPVARIANT *id, PROPVARIANT *value)
{
@@ -242,7 +219,7 @@ static HRESULT WINAPI MetadataHandler_GetValue(IWICMetadataWriter *iface,
HRESULT hr = WINCODEC_ERR_PROPERTYNOTFOUND;
MetadataHandler *This = impl_from_IWICMetadataWriter(iface);
- TRACE("(%p,%p,%p,%p)\n", iface, schema, id, value);
+ TRACE("(%p,%s,%s,%p)\n", iface, wine_dbgstr_variant((const VARIANT *)schema), wine_dbgstr_variant((const VARIANT *)id), value);
if (!id) return E_INVALIDARG;
@@ -252,10 +229,10 @@ static HRESULT WINAPI MetadataHandler_GetValue(IWICMetadataWriter *iface,
{
if (schema && This->items[i].schema.vt != VT_EMPTY)
{
- if (propvar_cmp(schema, &This->items[i].schema) != 0) continue;
+ if (PropVariantCompareEx(schema, &This->items[i].schema, 0, PVCF_USESTRCMPI) != 0) continue;
}
- if (propvar_cmp(id, &This->items[i].id) != 0) continue;
+ if (PropVariantCompareEx(id, &This->items[i].id, 0, PVCF_USESTRCMPI) != 0) continue;
hr = value ? PropVariantCopy(value, &This->items[i].value) : S_OK;
break;
--
2.13.1
More information about the wine-patches
mailing list