[PATCH] webservices: fixed memory leak in build_custom_header (Coverity)
Marcus Meissner
marcus at jet.franken.de
Tue Jun 20 02:14:46 CDT 2017
CID 1412746 Resource leak
(sorry for not bundling, got distracted on the weekend and only sent
the first)
Signed-off-by: Marcus Meissner <marcus at jet.franken.de>
---
dlls/webservices/msg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/webservices/msg.c b/dlls/webservices/msg.c
index f27aceac5f..1b5ec04137 100644
--- a/dlls/webservices/msg.c
+++ b/dlls/webservices/msg.c
@@ -1418,7 +1418,7 @@ static HRESULT build_custom_header( struct msg *msg, const WS_XML_STRING *name,
if (!(header = alloc_header( 0, FALSE, name, ns ))) return E_OUTOFMEMORY;
- if (!msg->writer && (hr = WsCreateWriter( NULL, 0, &msg->writer, NULL )) != S_OK) return hr;
+ if (!msg->writer && (hr = WsCreateWriter( NULL, 0, &msg->writer, NULL )) != S_OK) goto done;
if ((hr = WsCreateXmlBuffer( msg->heap, NULL, 0, &buf, NULL )) != S_OK) goto done;
if ((hr = WsSetOutputToBuffer( msg->writer, buf, NULL, 0, NULL )) != S_OK) goto done;
if ((hr = write_custom_header( msg->writer, name, ns, type, desc, option, value, size )) != S_OK) goto done;
--
2.13.1
More information about the wine-patches
mailing list