[PATCH] regedit: Free the binary data buffer after saving the new value (Coverity)

Hugh McMaster hugh.mcmaster at outlook.com
Wed Jun 28 05:47:29 CDT 2017


Signed-off-by: Hugh McMaster <hugh.mcmaster at outlook.com>
---
 programs/regedit/edit.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/programs/regedit/edit.c b/programs/regedit/edit.c
index 403def433f..2c47bdc03b 100644
--- a/programs/regedit/edit.c
+++ b/programs/regedit/edit.c
@@ -165,6 +165,7 @@ static INT_PTR CALLBACK bin_modify_dlgproc(HWND hwndDlg, UINT uMsg, WPARAM wPara
             {
                 SendDlgItemMessageW(hwndDlg, IDC_VALUE_DATA, HEM_GETDATA, (WPARAM)cbData, (LPARAM)pData);
                 lRet = RegSetValueExW(params->hKey, params->lpszValueName, 0, REG_BINARY, pData, cbData);
+                HeapFree(GetProcessHeap(), 0, pData);
             }
             else
                 lRet = ERROR_OUTOFMEMORY;
-- 
2.11.0




More information about the wine-patches mailing list