[PATCH 3/3] wininet/test: Improve tests for InternetGetConnectedStateEx
Jacek Caban
jacek at codeweavers.com
Mon Mar 6 08:24:39 CST 2017
Hi Bruno,
On 06.03.2017 05:24, Bruno Jesus wrote:
> - ok(sz - 1 == lstrlenW(buffer), "Expected %u bytes, got %u\n", sz - 1, lstrlenW(buffer));
> + if (flags & INTERNET_CONNECTION_MODEM)
> + ok(lstrlenW(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenW(buffer));
> + else
> + ok(sz - 1 == lstrlenW(buffer), "Expected %u bytes, got %u\n", sz - 1, lstrlenW(buffer));
You're dropping sz value tests in case is set. What is it set to in this
case? 0?
As a side note, you don't need strlen() to check if buffer is empty,
something like !*buffer will do the trick.
Thanks,
Jacek
More information about the wine-patches
mailing list