Index: templates/en/janitorial.template
===================================================================
RCS file: /home/wine/lostwages/templates/en/janitorial.template,v
retrieving revision 1.65
diff -u -p -r1.65 janitorial.template
--- templates/en/janitorial.template 25 Jan 2005 19:11:16 -0000 1.65
+++ templates/en/janitorial.template 25 Jan 2005 19:47:44 -0000
@@ -51,57 +51,6 @@
COM objects
- Use Interlocked functions in AddRef and Release methods
-
- Most OLE objects should be threadsafe, which requires use of the thread-safe
- increment and decrement functions InterlockedIncrement(&This->ref)
- and InterlockedDecrement(&This->ref) instead of This->ref++
- or This->ref--. See an example
- patch
- of how to fix this problem.
-
- To be consistent, references to This->ref in TRACE's should be
- avoided as well.
-
- As of Jan 11, 2005, there are at least 128 files in 25 dll's that appear to use thread
- unsafe operations and/or have TRACE's containing This->ref:
-
-
- - avifil32 : 7 files to check
-
- d3d8 : 12 files to check
-
- d3d9 : 17 files to check
-
- d3dx8 : 1 files to check
-
- d3dxof : 1 files to check
-
- dmband : 3 files to check
-
- dmcompos : 4 files checked
-
- dmscript : 3 files to check
-
- dmstyle : 8 files to check
-
- dmsynth : 3 files to check
-
- dmusic : 11 files to check
-
- dpnet : 2 files to check
-
- dsound : 7 files to check
-
- dswave : 2 files to check
-
- dxdiagn : 2 files to check
-
- mlang : 1 files to check
-
- msdmo : 1 files to check
-
- ole32 : 6 files to check
-
- oleaut32 : 3 files to check
-
- shdocvw : 7 files to check
-
- shell32 : 16 files to check
-
- shlwapi : 3 files to check
-
- urlmon : 1 files to check
-
- wined3d : 3 files to check
-
- winmm : 3 files to check
-
-
- Please note that patches have been submitted for the italic entries.
-
-
- - workers: James Hawkins, Joris Huizer, Paul Vriens
-
- status: First patch submitted and committed
-
- updated: Jan 8, 2005
-
-
IClassFactory->CreateInstance aggregation check
The CreateInstance method of IClassFactory takes pUnkOuter as the second
@@ -555,6 +504,23 @@
- workers: Oleg Prokhorov, Dimitrie O. Paun
- completed: Mar 10, 2004
+
+
+ Use Interlocked functions in AddRef and Release methods
+
+ Most OLE objects should be threadsafe, which requires use of the thread-safe
+ increment and decrement functions InterlockedIncrement(&This->ref)
+ and InterlockedDecrement(&This->ref) instead of This->ref++
+ or This->ref--. See an example
+ patch
+ of how to fix this problem.
+
+ To be consistent, references to This->ref in TRACE's should be
+ avoided as well.
+
+
+ - workers: James Hawkins, Joris Huizer, Paul Vriens
+
- completed: Jan 25, 2005