<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.10.1">
</HEAD>
<BODY>
<PRE>
Hi,
just a simple one (as suggested by Rob). For consistency sake we should use a
structmember after we've checked for NULL (not before).
<!--+GtkHTML:<DATA class="ClueFlow" key="orig" value="0">-->
Satisfies Coverity CID-654.
<!--+GtkHTML:<DATA class="ClueFlow" clear="orig">-->
Changelog
Use structmember after check for NULL
Cheers,
Paul.
---
dlls/comctl32/listview.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index fb4ecf6..4d3819d 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -5618,10 +5618,12 @@ static BOOL LISTVIEW_GetSubItemRect(LIST
{
POINT Position;
LVITEMW lvItem;
- INT nColumn = lprc->top;
+ INT nColumn;
if (!lprc) return FALSE;
+ nColumn = lprc->top;
+
TRACE("(nItem=%d, nSubItem=%ld)\n", nItem, lprc->top);
/* On WinNT, a subitem of '0' calls LISTVIEW_GetItemRect */
if (lprc->top == 0)
--
1.4.1
</PRE>
</BODY>
</HTML>