From f139d828d1f84a0df3bbdde9d07ec708c60c2cba Mon Sep 17 00:00:00 2001
From: Juan Lang <juan.lang@gmail.com>
Date: Mon, 17 Sep 2007 17:04:40 -0700
Subject: [PATCH] Introduce a space checking helper for functions that don't allocate memory,
and use it where appropriate
---
 dlls/crypt32/decode.c |   39 +++++++++++++++++++++++++++------------
 1 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c
index 9cc4c0c..02bb308 100644
--- a/dlls/crypt32/decode.c
+++ b/dlls/crypt32/decode.c
@@ -250,6 +250,27 @@ static BOOL CRYPT_DecodeEnsureSpace(DWOR
     return ret;
 }
 
+/* Helper function to check *pcbStructInfo and set it to the required size.
+ * Assumes pvStructInfo is not NULL.
+ */
+static BOOL CRYPT_DecodeCheckSpace(DWORD *pcbStructInfo, DWORD bytesNeeded)
+{
+    BOOL ret;
+
+    if (*pcbStructInfo < bytesNeeded)
+    {
+        *pcbStructInfo = bytesNeeded;
+        SetLastError(ERROR_MORE_DATA);
+        ret = FALSE;
+    }
+    else
+    {
+        *pcbStructInfo = bytesNeeded;
+        ret = TRUE;
+    }
+    return ret;
+}
+
 /* tag:
  *     The expected tag of the item.  If tag is 0, decodeFunc is called
  *     regardless of the tag value seen.
@@ -705,8 +726,7 @@ static BOOL WINAPI CRYPT_AsnDecodeDerBlo
 
         if (!pvStructInfo)
             *pcbStructInfo = bytesNeeded;
-        else if ((ret = CRYPT_DecodeEnsureSpace(dwFlags, pDecodePara, 
-         pvStructInfo, pcbStructInfo, bytesNeeded)))
+        else if ((ret = CRYPT_DecodeCheckSpace(pcbStructInfo, bytesNeeded)))
         {
             CRYPT_DER_BLOB *blob;
 
@@ -3055,8 +3075,7 @@ static BOOL CRYPT_AsnDecodeIntInternal(c
     {
         if (!pvStructInfo)
             *pcbStructInfo = sizeof(int);
-        else if ((ret = CRYPT_DecodeEnsureSpace(dwFlags, NULL,
-         pvStructInfo, pcbStructInfo, sizeof(int))))
+        else if ((ret = CRYPT_DecodeCheckSpace(pcbStructInfo, sizeof(int))))
         {
             int val, i;
 
@@ -3515,8 +3534,8 @@ static BOOL CRYPT_AsnDecodeUtcTimeIntern
                 {
                     if (!pvStructInfo)
                         *pcbStructInfo = sizeof(FILETIME);
-                    else if ((ret = CRYPT_DecodeEnsureSpace(dwFlags, NULL,
-                     pvStructInfo, pcbStructInfo, sizeof(FILETIME))))
+                    else if ((ret = CRYPT_DecodeCheckSpace(pcbStructInfo,
+                     sizeof(FILETIME))))
                         ret = SystemTimeToFileTime(&sysTime,
                          (FILETIME *)pvStructInfo);
                 }
@@ -3621,14 +3640,10 @@ static BOOL CRYPT_AsnDecodeGeneralizedTi
                 {
                     if (!pvStructInfo)
                         *pcbStructInfo = sizeof(FILETIME);
-                    else if ((ret = CRYPT_DecodeEnsureSpace(dwFlags, NULL,
-                     pvStructInfo, pcbStructInfo, sizeof(FILETIME))))
-                    {
-                        if (dwFlags & CRYPT_DECODE_ALLOC_FLAG)
-                            pvStructInfo = *(BYTE **)pvStructInfo;
+                    else if ((ret = CRYPT_DecodeCheckSpace(pcbStructInfo,
+                     sizeof(FILETIME))))
                         ret = SystemTimeToFileTime(&sysTime,
                          (FILETIME *)pvStructInfo);
-                    }
                 }
             }
         }
-- 
1.4.1