From 231bf2afe1f57abdbb84db2e364ce2a64deb7fc0 Mon Sep 17 00:00:00 2001 From: Vincent Povirk Date: Sun, 13 Dec 2009 18:21:54 -0600 Subject: [PATCH 2/3] ole32: Remove an unnecessary special case in StorageBaseImpl_CopyTo. Opening a storage when it has already been opened now fails with STG_E_ACCESSDENIED. If we attempt to copy a storage to its own child, this will happen during the copy. --- dlls/ole32/storage32.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c index 00ffe89..2d2c3d6 100644 --- a/dlls/ole32/storage32.c +++ b/dlls/ole32/storage32.c @@ -1674,16 +1674,6 @@ static HRESULT WINAPI StorageBaseImpl_CopyTo( goto cleanup; /* - * Check if destination storage is not a child of the source - * storage, which will cause an infinite loop - */ - if (pstgChild == pstgDest) - { - hr = STG_E_ACCESSDENIED; - goto cleanup; - } - - /* * create a new storage in destination storage */ hr = IStorage_CreateStorage( pstgDest, curElement.pwcsName, -- 1.6.3.3